Skip to content

Commit

Permalink
orientation: remove deprecated link_type, wcs_use_affine
Browse files Browse the repository at this point in the history
  • Loading branch information
kecnry committed Jan 9, 2025
1 parent e8510da commit 446ae82
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 23 deletions.
2 changes: 2 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ Cubeviz
Imviz
^^^^^

- orientation plugin: ``link_type`` and ``wcs_use_affine`` (previously deprecated) have now been removed. [#3385]

Mosviz
^^^^^^

Expand Down
22 changes: 1 addition & 21 deletions jdaviz/configs/imviz/plugins/orientation/orientation.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,33 +152,13 @@ def user_api(self):
return PluginUserApi(
self,
expose=(
'align_by', 'link_type', 'wcs_fast_approximation', 'wcs_use_affine',
'align_by', 'wcs_fast_approximation',
'delete_subsets', 'viewer', 'orientation',
'rotation_angle', 'east_left', 'add_orientation',
'set_north_up_east_left', 'set_north_up_east_right',
)
)

@property
@deprecated(since="4.0", alternative="align_by")
def link_type(self):
return self.align_by

@link_type.setter
@deprecated(since="4.0", alternative="align_by")
def link_type(self, link_type):
self.align_by = link_type

@property
@deprecated(since="4.0", alternative="wcs_fast_approximation")
def wcs_use_affine(self):
return self.wcs_fast_approximation

@wcs_use_affine.setter
@deprecated(since="4.0", alternative="wcs_fast_approximation")
def wcs_use_affine(self, wcs_use_affine):
self.wcs_fast_approximation = wcs_use_affine

def _link_image_data(self):
self.linking_in_progress = True
try:
Expand Down
2 changes: 0 additions & 2 deletions jdaviz/configs/imviz/tests/test_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
import pytest


@pytest.mark.filterwarnings(r"ignore:The link_type function is deprecated")
@pytest.mark.filterwarnings(r"ignore:The wcs_use_affine function is deprecated")
def test_plugin_user_apis(imviz_helper):
for plugin_name, plugin_api in imviz_helper.plugins.items():
plugin = plugin_api._obj
Expand Down

0 comments on commit 446ae82

Please sign in to comment.