Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specutils 2 compatibility #2922

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented Jun 20, 2024

Replaces #2762 after a significant rebase, with a better title and branch name that are more accurate to the scope of the PR. Still in draft, need to update tests

@rosteen rosteen added this to the 4.0 milestone Jun 20, 2024
@github-actions github-actions bot added documentation Explanation of code and concepts cubeviz specviz mosviz testing imviz plugin Label for plugins common to multiple configurations specviz2d labels Jun 20, 2024
@rosteen rosteen modified the milestones: 4.0, 4.1 Oct 17, 2024
@rosteen rosteen modified the milestones: 4.1, 4.2 Dec 23, 2024
@rosteen rosteen force-pushed the specutils-2-compatibility branch 3 times, most recently from 83b16e0 to dabf631 Compare January 6, 2025 15:34
Fix coords mouseover when SkyCoord is before SpectralCoord

More debugging

Fix slice with different spectral_axis_index, add specutils_format kwarg to cubeviz parser

Remove unused import

Remove ESA parser from commissioning [skip ci]

Generalizing coords_info to handle spectral axis first or last [ci skip]

Working on debugging aperture photometry

Need to pull meta from data not comp

Fix aperture photometry and wrong coord order in coords_info

Fix codestyle, delete defunct case in parser

Change Spectrum1D to Spectrum

Change class name in recent code additions

Get spectral extraction working again for cylinder case

Debugging wavelength dependent case

Make sure spectral extraction result is linked when added to data collection

Moved fix to correct place

Fix indents

Remove stray code from rebase

Update missed Spectrum1D

Debugging cubeviz parser

First start on fixing testt

Fix bad rebase in spectral extraction

Starting to work through test failures

Working through test failures

Debugging spectral extraction
@rosteen rosteen force-pushed the specutils-2-compatibility branch from dabf631 to 9fcb2bc Compare January 6, 2025 15:34
Finish fixing codestyle, probably still need functional fixes
@rosteen rosteen force-pushed the specutils-2-compatibility branch from 787141a to f9d26cf Compare January 6, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz documentation Explanation of code and concepts imviz mosviz plugin Label for plugins common to multiple configurations specviz specviz2d testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant