Fix linkcheck #3351
Merged
Fix linkcheck #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
added
bug
pllim
requested review from
rosteen,
javerbukh,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
rosteen
approved these changes
Dec 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3351 +/- ##
=======================================
Coverage 88.80% 88.80%
=======================================
Files 125 125
Lines 19155 19155
=======================================
Hits 17010 17010
Misses 2145 2145 ☔ View full report in Codecov by Sentry. |
|
Roman failures unrelated. Thanks for the quick review/approval! |
This comment was marked as resolved.
This comment was marked as resolved.
|
Meh, cron doesn't run in backport branch anyway, so don't really have to backport. I will change milestone. |
pllim
removed
Still Needs Manual Backport
💤backport-v4.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this when looking at #3269 failures. The link works but linkcheck thinks it is anchor so we just ignore it.