Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roman_datamodels compatibility, move romandeps test to CI workflows #3353

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

bmorris3
Copy link
Contributor

Description

Tests that rely on the optional Roman dependencies are currently failing since updates to roman_datamodels and rad that now save ramps as numpy arrays rather than astropy quantities. I've bumped the pin on rdm, and revised how units are handled for that data model in jdaviz. I've also moved the romandeps cron test into ci_workflows under allowed failures, so we'll have faster warning next time we're out of sync.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@github-actions github-actions bot added testing plugin Label for plugins common to multiple configurations rampviz labels Dec 12, 2024
@bmorris3 bmorris3 added this to the 4.0.1 milestone Dec 12, 2024
@bmorris3 bmorris3 added the no-changelog-entry-needed changelog bot directive label Dec 12, 2024
@bmorris3 bmorris3 marked this pull request as ready for review December 12, 2024 16:59
@bmorris3 bmorris3 added the Extra CI Run cron jobs in PR label Dec 12, 2024
@pllim pllim added the 💤backport-v4.0.x on-merge: backport to v4.0.x label Dec 12, 2024
and let Roman use remote data
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.78%. Comparing base (cf9664f) to head (e180621).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
jdaviz/configs/rampviz/plugins/parsers.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3353      +/-   ##
==========================================
- Coverage   88.80%   88.78%   -0.02%     
==========================================
  Files         125      125              
  Lines       19155    19161       +6     
==========================================
+ Hits        17010    17012       +2     
- Misses       2145     2149       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

If your Roman test suite does not use remote data at all (e.g, CRDS or MAST or Box), please remove toxposargs: --remote-data. Otherwise, feel free to merge.

@pllim pllim merged commit 05e9afb into spacetelescope:main Dec 12, 2024
17 of 19 checks passed
Copy link

lumberbot-app bot commented Dec 12, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v4.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 05e9afb0fdc11d062e52b483b11ee5ac1e8577ec
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #3353: roman_datamodels compatibility, move `romandeps` test to CI workflows'
  1. Push to a named branch:
git push YOURFORK v4.0.x:auto-backport-of-pr-3353-on-v4.0.x
  1. Create a PR against branch v4.0.x, I would have named this PR:

"Backport PR #3353 on branch v4.0.x (roman_datamodels compatibility, move romandeps test to CI workflows)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@pllim
Copy link
Contributor

pllim commented Dec 12, 2024

@bmorris3 are you able to do a manual backport? Thanks!

bmorris3 added a commit to bmorris3/jdaviz that referenced this pull request Dec 13, 2024
…spacetelescope#3353)

* rdm compatibility, move romandeps test to CI workflows

* Fix ci_workflows.yml

---------

Co-authored-by: P. L. Lim <[email protected]>
(cherry picked from commit 05e9afb)
kecnry pushed a commit that referenced this pull request Dec 13, 2024
…#3353) (#3357)

* rdm compatibility, move romandeps test to CI workflows

* Fix ci_workflows.yml

---------

Co-authored-by: P. L. Lim <[email protected]>
(cherry picked from commit 05e9afb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extra CI Run cron jobs in PR no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations rampviz testing 💤backport-v4.0.x on-merge: backport to v4.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants