-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roman_datamodels compatibility, move romandeps
test to CI workflows
#3353
Conversation
and let Roman use remote data
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3353 +/- ##
==========================================
- Coverage 88.80% 88.78% -0.02%
==========================================
Files 125 125
Lines 19155 19161 +6
==========================================
+ Hits 17010 17012 +2
- Misses 2145 2149 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
If your Roman test suite does not use remote data at all (e.g, CRDS or MAST or Box), please remove toxposargs: --remote-data
. Otherwise, feel free to merge.
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
@bmorris3 are you able to do a manual backport? Thanks! |
…spacetelescope#3353) * rdm compatibility, move romandeps test to CI workflows * Fix ci_workflows.yml --------- Co-authored-by: P. L. Lim <[email protected]> (cherry picked from commit 05e9afb)
…#3353) (#3357) * rdm compatibility, move romandeps test to CI workflows * Fix ci_workflows.yml --------- Co-authored-by: P. L. Lim <[email protected]> (cherry picked from commit 05e9afb)
Description
Tests that rely on the optional Roman dependencies are currently failing since updates to
roman_datamodels
andrad
that now save ramps as numpy arrays rather than astropy quantities. I've bumped the pin on rdm, and revised how units are handled for that data model in jdaviz. I've also moved the romandeps cron test intoci_workflows
under allowed failures, so we'll have faster warning next time we're out of sync.Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.