Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jt listener mergechanges #3354

Closed
wants to merge 60 commits into from
Closed

Jt listener mergechanges #3354

wants to merge 60 commits into from

Conversation

james-trayford
Copy link

testing CI

javerbukh and others added 30 commits July 31, 2024 17:27
@javerbukh
Create audified cube and use with spectrum at spaxel tool
6049d9a
@javerbukh
Add Sonify Data plugin and connect to spectrum per spaxel tool
627a34f
@javerbukh
Fix errors
9e98b32
@javerbukh
Try moving code to mixin
e6d52b4
@javerbukh
Move code to viewers.py
0080b2f
@javerbukh
Remove print statements
4b01304
Patches:
505f73f 
- Fix sigcube alignment with other cubes [get rid of transpose]
- Add percentile cut option that enables some rough feature isolation without full continuum subtraction
- Protect against cubes w/NaNs
fix np import
89d6fff
add audio frequency range choice and equal loudness normalisation opt…
5c67736 
…ions
@javerbukh
Create dropdown to select output sound device
d8937c5
@javerbukh
Various updates and QOL improvements
75b7ded
@javerbukh
Connect volume level in viewer to sonify plugin
9d6844d
add volume attenuation functionality
1d1417c
add sound device switching
6421ee5
feed ELN flag to Image Viewer
352eff9
@javerbukh
Merge pull request spacetelescope#18 from james-trayford/sonify-plugi…
a7d501e 
…n-updates-jt

Sonify plugin updates jt
@javerbukh
Enable start stop stream and strauss soft dependency
ceafbb0
@javerbukh
Add note to plugin when strauss is not downloaded
a4811e4
@javerbukh
Add strauss as soft dependency
2a270ec
@javerbukh
Get build devices method working on windows
13f37a8
ensure sound generation always uses the current spectrum-at-spaxel wl…
4a1d628 
… range
post rebase clean-up (remove prints and rogue spaces)
a05937d
this syntax seems to work to install strauss on our specific git bran…
0f0eb87 
…ch for now, while awaitin PyPI release
@javerbukh
Merge pull request spacetelescope#19 from james-trayford/sonify-plugi…
a56b26e 
…n-updates-jt

Some more functionality tweaks
@javerbukh
Update code to be PEP8
18634ea
@javerbukh
PEP8 fixes
cc51183
@javerbukh
Merge branch 'main' into sonify-plugin-updates
5d308ea
@javerbukh
Remove old code
c6de013
@javerbukh
Fix test
eaae60f
@javerbukh
Fix test 2
9682321
javerbukh and others added 24 commits November 8, 2024 15:49
@javerbukh
Remove unused import
a5ef389
@javerbukh
Add documentation and a test
a66beef
@javerbukh
Add install instructions to warning when package is not present
b4b64e0
@javerbukh
Fix test failure
99d04e8
@javerbukh
Add plugin description
9747650
@javerbukh
Add plugin description
b1d5806
@javerbukh
Finish test and add standalone hook
2d0c5a4
@javerbukh
Grey out start/stop stream and fix code style
ae98601
@javerbukh
Update docs and change disable message for plugin without strauss ins…
91ed211 
…talled
@javerbukh @rosteen
Update jdaviz/configs/cubeviz/plugins/sonify_data/sonify_data.py
30ddca8 
Co-authored-by: Ricky O'Steen <[email protected]>
@javerbukh
Merge branch 'main' into sonify-plugin-updates
1ab90f6
@javerbukh
Add cron job for strauss
434a42a
@javerbukh
Add strauss deps to tox.ini
bf4fa3f
@javerbukh
Add sounddevice as dependency
6249a8c
@javerbukh
Add port audio dep
14c1602
@javerbukh
Try manually adding install for libportaudio2
2dc155b
@pllim
Try different order and Python version
89dfcd2
@pllim
not a Python package
8172cdd
@javerbukh
Catch case with no sound devices and set plugin to disabled
b552edc
catch no sound device case without errors in other cases, also remove…
30e8ad2 
… tqdm use and import, and use main branch strauss which should now work for JDAViz!
@javerbukh
Fix check for sound devices
4494ba5
i needed these quotes for the pip suggestion to work
92982bd
remove debug print
17fd0e5
revert change
dc478ce
@github-actions github-actions bot added documentation Explanation of code and concepts cubeviz testing imviz plugin Label for plugins common to multiple configurations labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosteen rosteen Awaiting requested review from rosteen rosteen will be requested when the pull request is marked ready for review rosteen is a code owner

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh will be requested when the pull request is marked ready for review javerbukh is a code owner

@pllim pllim Awaiting requested review from pllim pllim will be requested when the pull request is marked ready for review pllim is a code owner

@kecnry kecnry Awaiting requested review from kecnry kecnry will be requested when the pull request is marked ready for review kecnry is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 will be requested when the pull request is marked ready for review bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay will be requested when the pull request is marked ready for review haticekaratay is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 will be requested when the pull request is marked ready for review cshanahan1 is a code owner

@gibsongreen gibsongreen Awaiting requested review from gibsongreen gibsongreen will be requested when the pull request is marked ready for review gibsongreen is a code owner

Assignees
No one assigned
Labels
cubeviz documentation Explanation of code and concepts imviz plugin Label for plugins common to multiple configurations testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@james-trayford @javerbukh @pllim