Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix repr for select component #3367

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Dec 19, 2024

Description

... this time with a comment so it isn't accidentally undone (blaming previous self 🙄 )

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Dec 19, 2024
@kecnry kecnry added this to the 4.1 milestone Dec 19, 2024
@kecnry kecnry marked this pull request as ready for review December 19, 2024 17:50
@kecnry kecnry enabled auto-merge (squash) December 19, 2024 17:53
@kecnry
Copy link
Member Author

kecnry commented Dec 19, 2024

remote data failures are unrelated

@kecnry kecnry disabled auto-merge December 19, 2024 18:28
@kecnry kecnry merged commit 0693231 into spacetelescope:main Dec 19, 2024
21 of 25 checks passed
@kecnry kecnry deleted the select-repr branch December 19, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants