Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manual backport of PR 3383 #3386

Merged
merged 1 commit into from
Jan 10, 2025
Merged

manual backport of PR 3383 #3386

merged 1 commit into from
Jan 10, 2025

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jan 10, 2025

Manual backport of #3383.

@kecnry
data-menu: handle viewer rename properly (spacetelescope#3383)
a0ef414 
* data-menu: handle viewer rename properly
@kecnry kecnry added bug Something isn't working trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Jan 10, 2025
@kecnry kecnry added this to the 4.1.1 milestone Jan 10, 2025
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Jan 10, 2025
pllim
pllim approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as devdeps failures are unrelated. Thanks.

@kecnry kecnry merged commit 495e49a into spacetelescope:v4.1.x Jan 10, 2025
30 of 31 checks passed
@kecnry kecnry deleted the backport-3383 branch January 10, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

@rosteen rosteen Awaiting requested review from rosteen rosteen is a code owner

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 is a code owner

@gibsongreen gibsongreen Awaiting requested review from gibsongreen gibsongreen is a code owner

Assignees
No one assigned
Labels
bug Something isn't working no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Milestone
4.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kecnry @pllim