Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DataMenu keeps scrolling in view after app is out of view #3391

Merged

Conversation

mariobuikhuizen
Copy link
Collaborator

@mariobuikhuizen mariobuikhuizen commented Jan 16, 2025

Description

This pull request is to address the DataMenu being visible after the app has scrolled out of view.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Jan 16, 2025
@kecnry kecnry added this to the 4.1.1 milestone Jan 16, 2025
@kecnry kecnry added the backport-v4.1.x on-merge: backport to v4.1.x label Jan 16, 2025
@rosteen
Copy link
Collaborator

rosteen commented Jan 16, 2025

This is much better than it was, thanks! I still find it interesting that the menu gets put on top of the Jupyter lab menus (see below) rather than being confined to the app area, but this is a great improvement.

Screenshot 2025-01-16 at 11 44 47 AM

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed - and love the simple solution! Thanks!

@kecnry kecnry merged commit 3107b87 into spacetelescope:main Jan 16, 2025
16 of 18 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Jan 16, 2025
pllim added a commit that referenced this pull request Jan 16, 2025
…1-on-v4.1.x

Backport PR #3391 on branch v4.1.x (fix: DataMenu keeps scrolling in view after app is out of view)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.1.x on-merge: backport to v4.1.x plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants