Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Max pin glue-core to 1.20.0 #3401

Closed
wants to merge 1 commit into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jan 21, 2025

due to breaking changes in newer releases

Description

This pull request is to max pin glue-core in anticipation of #3238 . Also would fix devdeps.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

due to breaking changes in newer releases
@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive backport-v4.1.x on-merge: backport to v4.1.x labels Jan 21, 2025
@pllim pllim added this to the 4.1.1 milestone Jan 21, 2025
@rosteen
Copy link
Collaborator

rosteen commented Jan 21, 2025

I thought the breaking change was coming in 1.21.2, can we not max pin to 1.21.1? We also planned to only merge this into 4.1.x, not main, since main will be fixed via #3238 (we should be able to see devdeps pass there after the source_id bugfix is merged).

@pllim
Copy link
Contributor Author

pllim commented Jan 21, 2025

hmm ok #3402

@pllim pllim closed this Jan 21, 2025
@pllim pllim deleted the max-pin-glue-so-sticky branch January 21, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.1.x on-merge: backport to v4.1.x no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants