-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially revert #8042 and add CI in order to allow Python 3.12 support. #8093
Partially revert #8042 and add CI in order to allow Python 3.12 support. #8093
Conversation
If/when/as this PR is merged, we can also revert #8057 |
Looks like jwst still uses |
7839073
to
917c97f
Compare
This requires #8095 in order to function properly as |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8093 +/- ##
=======================================
Coverage 75.94% 75.94%
=======================================
Files 460 460
Lines 37625 37629 +4
=======================================
+ Hits 28573 28577 +4
Misses 9052 9052
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
689fd5b
to
2dc09ab
Compare
.github/workflows/ci.yml
Outdated
- linux: py311-stdevdeps-xdist | ||
- linux: py311-devdeps-xdist | ||
- linux: py311-xdist-cov | ||
- linux: py312-stdevdeps-xdist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So these various entries look to me like we're keeping tests using python 3.9 and 3.10, but getting rid of all tests using 3.11 and replacing them with 3.12? Why aren't we keeping any 3.11 tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 72 runs the python 3.11 tests. If you would prefer I could just keep it Python 3.11 for the macos
and stdevdeps
jobs, only adding the additional py312-xdist
job? I updated these because in the past we seem to have updated them to the latest version of python supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we'll be delivering our next build under 3.11, I'd prefer to keep both the Linux and Macos entries using 3.11, but then use 3.12 for everything that involves latest/dev dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, it now just adds a 3.12 linux job to the standard CI and changes the devdeps related jobs to 3.12
7604d41
to
b5b8525
Compare
a40d386
to
533c09b
Compare
)" This reverts commit 68b8c20.
533c09b
to
9b6f1f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging this should maybe have prompted a build - the readme is now updated to imply support of python 3.12, but no release supports 3.12 yet. |
Resolves JP-nnnn
Closes #8044
This PR enables Python 3.12 support for JWST, the main issue preventing this was solved by #8033.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR