Release V1.4.0 to stable #915

BradleySappington · 2024-09-13T18:31:25Z

Release V1.4.0 to stable

Improve trending plots, particularly wfe_histogram arrows display

Bumps [photutils](https://github.com/astropy/photutils) from 1.12.0 to 1.13.0. - [Release notes](https://github.com/astropy/photutils/releases) - [Changelog](https://github.com/astropy/photutils/blob/main/CHANGES.rst) - [Commits](astropy/photutils@1.12.0...1.13.0) --- updated-dependencies: - dependency-name: photutils dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…tibility

…1.13.0 build(deps): bump photutils from 1.12.0 to 1.13.0

Bumps [scipy](https://github.com/scipy/scipy) from 1.13.0 to 1.14.0. - [Release notes](https://github.com/scipy/scipy/releases) - [Commits](scipy/scipy@v1.13.0...v1.14.0) --- updated-dependencies: - dependency-name: scipy dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

more strict units handling; fixes some issues for astropy 6.0.0 compatibility

print cache key

add dedicated cache workflow that can be called by other projects

fix syntax error in `.github/workflows/download_data.yml`

…bined

[CI] add names to workflows and fix data version parsing with `echo` and `awk`

[CI] set a generalized cache path, allowing multiple data caches to be combined downstream

…tents, too.

Docs improvements, including for matching PSFs to data

…psf-st into ifu_mode_improvements_part2

Enhance capabilities to simulate PSFs with larger JWST pupil

IFU mode improvements, continued

Roman docs & figures updates

add CI tests for mast_wss, in test_mast_wss.py

Pre release 140

pep8speaks · 2024-09-13T18:31:39Z

Hello @BradleySappington, Thank you for submitting the Pull Request !

In the file docs/conf.py:

Line 124:1: E265 block comment should start with '# '
Line 128:1: E265 block comment should start with '# '
Line 153:1: E265 block comment should start with '# '

In the file webbpsf/detectors.py:

Line 564:1: E101 indentation contains mixed spaces and tabs
Line 567:1: E101 indentation contains mixed spaces and tabs
Line 568:1: E101 indentation contains mixed spaces and tabs
Line 570:1: E101 indentation contains mixed spaces and tabs
Line 616:91: E225 missing whitespace around operator
Line 616:91: W504 line break after binary operator
Line 642:1: E101 indentation contains mixed spaces and tabs
Line 643:1: E101 indentation contains mixed spaces and tabs
Line 645:55: E226 missing whitespace around arithmetic operator
Line 645:66: E226 missing whitespace around arithmetic operator
Line 645:71: E226 missing whitespace around arithmetic operator
Line 645:126: E501 line too long (138 > 125 characters)
Line 647:31: E226 missing whitespace around arithmetic operator
Line 648:35: E226 missing whitespace around arithmetic operator
Line 653:6: E111 indentation is not a multiple of four
Line 653:6: E117 over-indented
Line 665:6: E111 indentation is not a multiple of four
Line 669:6: E111 indentation is not a multiple of four
Line 670:10: E111 indentation is not a multiple of four
Line 671:6: E111 indentation is not a multiple of four
Line 672:10: E111 indentation is not a multiple of four
Line 673:10: E111 indentation is not a multiple of four
Line 674:10: E111 indentation is not a multiple of four
Line 675:6: E111 indentation is not a multiple of four

In the file webbpsf/match_data.py:

Line 91:37: E261 at least two spaces before inline comment

In the file webbpsf/tests/test_mast_wss.py:

Line 36:13: E127 continuation line over-indented for visual indent

In the file webbpsf/tests/test_nirspec.py:

Line 101:1: E303 too many blank lines (3)
Line 120:1: E302 expected 2 blank lines, found 1

In the file webbpsf/trending.py:

Line 387:70: E226 missing whitespace around arithmetic operator
Line 391:17: E124 closing bracket does not match visual indentation

In the file webbpsf/webbpsf_core.py:

Line 1666:19: E126 continuation line over-indented for hanging indent
Line 2108:19: E126 continuation line over-indented for hanging indent
Line 2109:13: E131 continuation line unaligned for hanging indent

If you have not done so, please lint your code in accordance with best practices.

obi-wan76

Looks good, thanks!

mperrin and others added 30 commits June 11, 2024 14:51

set clip_on to avoid labels outside plot axes

7e5ed1c

improve wfe_histogram arrows display; add min_wfe and max_wfe options

f26a1e4

pep8 style fixes

7aff283

Merge pull request #870 from mperrin/trending_plot_fixes

7c74ffb

Improve trending plots, particularly wfe_histogram arrows display

add dedicated cache workflow that can be called by other projects

aa2ab6a

test with this branch (remove before merge)

7e71ff5

fix extract and path

4431c74

remove schedule trigger

5557ff8

add cycle 3 routine WFS PIDs

afbff70

more strict units handling; fixes some issues for astropy 6.0.0 compa…

d4252a1

…tibility

Merge pull request #872 from spacetelescope/dependabot/pip/photutils-…

23c180e

…1.13.0 build(deps): bump photutils from 1.12.0 to 1.13.0

some additional units handling

15f5374

Merge pull request #879 from mperrin/fix_unit_bug_in_fast_datacube

89fcb26

more strict units handling; fixes some issues for astropy 6.0.0 compatibility

rename cache.yml to download_data.yml

8c414eb

retrieve latest cache key by default

9ac4c72

print cache key

also trigger data download on a WebbPSF GitHub release

e79fdfd

small fix for WEBBPSF_PATH

eea2012

add comments to the top of the workflows indicating how to use them

3796c0a

Merge pull request #877 from zacharyburnett/ci/cache

5c437b6

add dedicated cache workflow that can be called by other projects

fix syntax error by just using == and ||

302c7ab

Merge pull request #882 from zacharyburnett/fix/download_data_workflow

0aec204

fix syntax error in `.github/workflows/download_data.yml`

add names to workflows

0347188

also fix version retrieval with echo

cebb230

set a generalized cache path, allowing multiple data caches to be com…

15376a6

…bined

Merge pull request #881 from zacharyburnett/ci/workflow_names

6b65649

[CI] add names to workflows and fix data version parsing with `echo` and `awk`

Merge pull request #883 from zacharyburnett/ci/general_cache_path

fb4dd05

[CI] set a generalized cache path, allowing multiple data caches to be combined downstream

create data directory when caching data

e18aee2

correct path to version.txt

63a2e08

mperrin and others added 23 commits September 10, 2024 16:49

Merge branch 'develop' into ifu_mode_improvements_part2

cf9a57a

Merge branch 'develop' into ifu_mode_improvements_part2

e67280f

Initial updates of Roman figures, along with python script

37e6d4c

fixed markdown caption

a35e5d7

Minor updates and rephrasing in docs page. Add docs into table of con…

1213260

…tents, too.

A few more tweaks to figs and rst

187e449

fixed rst captions

02629e4

fixed how_tos.py following lint

8d69ab9

add psf_grids.ipynb

d37fb3d

Updated Roman notebook

883bbbd

remove extra debug test cell

95abd06

add test_mast_wss.py

5380820

fixes from review

e686a22

Merge pull request #899 from mperrin/docs_improvements_v131

b45d82d

Docs improvements, including for matching PSFs to data

lint fixes

923748f

Merge branch 'ifu_mode_improvements_part2' of github.com:mperrin/webb…

d99fa5e

…psf-st into ifu_mode_improvements_part2

Merge pull request #908 from spacetelescope/webbpsf_load_wss_pupil_size

9cf185a

Enhance capabilities to simulate PSFs with larger JWST pupil

Merge pull request #890 from mperrin/ifu_mode_improvements_part2

2c128b5

IFU mode improvements, continued

Merge pull request #910 from Skyhawk172/roman-docs-updates

be0f790

Roman docs & figures updates

Merge pull request #911 from mperrin/add_test_mast_wss

6a616bd

add CI tests for mast_wss, in test_mast_wss.py

update versions of webbpsf-data and documentation

9b26e0d

more pre-release upates

cbfa5dc

Merge pull request #912 from spacetelescope/pre-release-140

beda656

Pre release 140

BradleySappington self-assigned this Sep 13, 2024

BradleySappington requested review from mperrin and obi-wan76 September 13, 2024 18:42

mperrin added this to the Release 1.4 milestone Sep 13, 2024

obi-wan76 approved these changes Sep 13, 2024

View reviewed changes

BradleySappington merged commit 9655645 into stable Sep 13, 2024
32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release V1.4.0 to stable #915

Release V1.4.0 to stable #915

BradleySappington commented Sep 13, 2024

pep8speaks commented Sep 13, 2024

obi-wan76 left a comment

Release V1.4.0 to stable #915

Release V1.4.0 to stable #915

Conversation

BradleySappington commented Sep 13, 2024

pep8speaks commented Sep 13, 2024

obi-wan76 left a comment

Choose a reason for hiding this comment