-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version release 1.5.0 #947
Conversation
To reflect its broader support for Roman as well as James Webb, WebbPSF is being migrated to a new repository: STPSF (Space Telescope PSF). | ||
This transition is being done in such a way as to maintain back-compatibility for existing code, and existing installations will continue to run as-is. | ||
This transitional period is ongoing now. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add another note that this release comes with a new data as well, So users need to download webbpsf-data 1.5 as well. We can mention PR 937 for more details about what changed in webbpsf-data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions on rel notes
docs/relnotes.rst
Outdated
WebbPSF IS BEING MIGRATED TO A NEW REPOSITORY: STPSF (Space Telescope PSF) | ||
To reflect its broader support for Roman as well as James Webb, WebbPSF is being migrated to a new repository: STPSF (Space Telescope PSF). | ||
This transition is being done in such a way as to maintain back-compatibility for existing code, and existing installations will continue to run as-is. | ||
This transitional period is ongoing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion. Let's tweak the text here slightly to rephrase, since the release notes text will be online long term, presumably long beyond the release of STPSF when the transitional period is no longer "now".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
docs/relnotes.rst
Outdated
Version 1.4.0 | ||
============= | ||
|
||
*2024 September* | ||
|
||
We are pleased to announce the release of the latest version of WebbPSF version 1.4.0, now available on PyPi and GitHub. This release comes with new features and improvements including but not limited to: | ||
|
||
**What's Changed** | ||
* [CI] allow manual run of `download_data.yml` to specify data URL by @zacharyburnett in https://github.com/spacetelescope/webbpsf/pull/914 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's going on here? Is this text maybe in the wrong place? I'm surprised this PR is changing the release notes for version 1.4 back in the past. I see several of the PRs linked below are definitely more recent, for instance 943, 944, 945 were all just last week, so definitely part of 1.5.0 rather than 1.4.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double pasted!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Release 1.5.0