Move build_pr_changes.py -> cli/check.py, clean-up

.pre-commit-config.yaml

@@ -67,13 +67,11 @@ repos:
         exclude: cli/_vendor
 
 -   repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.12.0
+    rev: v1.13.0
     hooks:
     -   id: mypy
         name: Run mypy
         exclude: cli/_vendor
-        additional_dependencies:
-        - pexpect
 
 -   repo: local
     hooks:
@@ -100,15 +98,13 @@ repos:
   - id: markdownlint
 
 -   repo: https://github.com/RobertCraigie/pyright-python
-    rev: v1.1.385
+    rev: v1.1.386
     hooks:
     -   id: pyright
         name: Run pyright
         exclude: cli/_vendor
         additional_dependencies:
-        - pexpect
         - typing-extensions
-        - types-pexpect
 
 - repo: https://github.com/codespell-project/codespell
   rev: v2.3.0
@@ -130,14 +126,10 @@ repos:
         # that also the GitHub Action currently uses:
         # language_version: "3.10"
         name: Run pytype
-        additional_dependencies: [pexpect]
-        args: ['build_pr_changes.py']
+        args: ['cli/check.py']
 
 -   repo: https://github.com/pylint-dev/pylint
     rev: v3.3.1
     hooks:
     -   id: pylint
         exclude: cli/_vendor
-        additional_dependencies:
-        - pexpect
-        - types-pexpect

cli/_vendor/pexpect/spawnbase.py

@@ -8,7 +8,7 @@
 from .expect import Expecter, searcher_string, searcher_re
 
 PY3 = (sys.version_info[0] >= 3)
-text_type = str if PY3 else unicode
+text_type = str if PY3 else unicode  # type:ignore[name-defined]
 
 class _NullCoder(object):
     """Pass bytes through unchanged."""

build_pr_changes.py → cli/check.py

@@ -25,13 +25,7 @@
 from subprocess import getoutput
 from typing import Any, Dict, List, Tuple, TypeAlias
 
-try:
-    import pexpect
-except ImportError:
-    print("pexpect missing, please run:")
-    print("sudo apt-get -y install python3-pexpect || pip3 install pexpect")
-    sys.exit(1)
-
+from _vendor import pexpect
 
 ExitCode: TypeAlias = int
 Success: ExitCode = 0

gh-spack-pr

@@ -0,0 +1 @@
+cli/check.py

pyproject.toml

@@ -71,4 +71,5 @@ ignore = ['']
 # extraPaths = ['']
 
 [tool.pytype]
+inputs = ["cli/check.py"]
 exclude = ["cli/_vendor/**"]