webhook-handler: ignore install times for failed jobs #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
reviewed
Dec 18, 2024
mvandenburgh
force-pushed
the
skip-install-times-when-failed
branch
from
85ae96a to
761a9fe
Compare
Failed jobs will frequently have *no artifacts*. This change introduces a new exception type to distinguish between no artifacts and missing artifacts.
mvandenburgh
force-pushed
the
skip-install-times-when-failed
branch
from
761a9fe to
b95130a
Compare
jjnesbitt
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a build job fails, it won't have an install_times.json.
@jjnesbitt this accounts for some, but not all, of the sentry errors complaining about missing install_times.json.