Add test for creating packages and specs #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`./manage.py migrate core --prune` should be run on the prod application after this.
mvandenburgh
previously approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several things to allow for this new test, aside from just adding the test itself.
The main thing is all migrations have been squashed into
0001_inital.py(I say squashed, but really this was achieved by deleting all migrations and re-runningmakemigrations). The reason for this is that when pytest was running these migrations as a part of its DB setup step, theRunPythonoperations were failing. I originally just commented these out, but I see no real downside in just squashing them all. Since0001_initialwill show as already applied in the DB, nothing will happen, and running./manage.py migrate core --prunewill remove the old migrations from the migration history.There is more work needed to properly set up testing infrastructure, and I will do that in a separate PR. At the moment, this test doesn't run automatically in CI, I simply wanted to have the test able to be run locally.