webhook handler: Add computed DB column for infrastructure errors #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
force-pushed
the
analyics-django5
branch
from
b4b70e2 to
f87eb15
Compare
|
I noticed we're including dev dependencies in |
Instead of manually filtering these out in metabase, this introduces a DB computed column that will handle that logic.
mvandenburgh
force-pushed
the
analyics-django5
branch
from
c812e39 to
24a5aac
Compare
jjnesbitt
reviewed
Jan 3, 2025
jjnesbitt
reviewed
Jan 3, 2025
jjnesbitt
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to just rely on this one column in our metabase dashboards, instead of adding a filtering clause for the different error taxonomy types that imply an infrastructure error and having to keep each dashboard up to date if we decide to add more.
Note,
GeneratedFieldwas introduced to the ORM in Django 5, so that's why I also did that upgrade here.