Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include public signing key when publishing stacks #1032

Merged

Conversation

scottwittenburg
Copy link
Collaborator

When moving the protected-publish job from spack gitlab pipelines to a dedicated cron job, I neglected to take care of publishing the signing key to the root mirror. This PR resolves that issue.

I tested this change by removing a spec from the s3://spack-binaries/v0.23.0 mirror, then building the imgae locally, and running the container to publish the v0.23.0 ref. After which, I could successfully install keys from that mirror:

$ git clone https://github.com/spack/spack.git
$ cd spack
$ git checkout v0.23.0
$ spack mirror add binaries s3://spack-binaries/v0.23.0
$ spack buildcache keys --install
==> Fetching s3://spack-binaries/v0.23.0/build_cache/_pgp/spack-public-binary-key.pub

@scottwittenburg scottwittenburg merged commit 0df5988 into spack:main Jan 10, 2025
14 checks passed
@scottwittenburg scottwittenburg deleted the protected-publish-signing-key branch January 10, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants