Allow service tagged runners to define CI_OIDC_REQUIRED
#957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows not erroring on OIDC setup
|
@kwryankrattiger this will stop these jobs from getting reported as "Failed", right? https://gitlab.spack.io/spack/spack/-/jobs/12825706 |
|
It still requires a PR to Spack, but yes the goal is to stop failing noop jobs. I still need to verify if this doesn't just abort the job with status 0 or if this exits the script and still runs the rest of CI. Honestly either is probably ok. This change should be safe to test in production as it is only changing the path of failure to being configurable to not fail. I don't think it is abusable since it affects runner types we don't really use for most of CI (they need v3). |
mvandenburgh
approved these changes
Oct 9, 2024
kwryankrattiger
added a commit
to kwryankrattiger/spack
that referenced
this pull request
Oct 11, 2024
kwryankrattiger
added a commit
to kwryankrattiger/spack
that referenced
this pull request
Oct 11, 2024
kwryankrattiger
added a commit
to spack/spack
that referenced
this pull request
Oct 15, 2024
arezaii
pushed a commit
to arezaii/spack
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows not erroring on OIDC setup for runners with service tag. Noop jobs use the service runners, but do not need access to S3 buckets. Jobs on these runners should not fail trying to find services they don't need.
If the variable
CI_OIDC_REQUIREDis set in the job running on the runner, the value will be used. This will likely only be set on thenoopjobs with a value of0.If the variable
CI_OIDC_REQUIREDis not set, the exit code will be1ref. spack/spack#46732