feat!: Enable multiarch snap builds for deployment on non-amd64 machines #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
BREAKING CHANGE: Shell support scripts no longer lock-in `SPACK_PYTHON` based on what the user has set in their environment. Instead, snap will set SPACK_PYTHON to the Python interpreter bundled inside the snap. This bundled Python interpreter provides the `clingo` module installed during spack's bootstrap process. Shell support patch now also patches out hints about enabling powershell support as well as .batch suppor. bash/zsh/sh shell support script now supports the $SPACK_COLOR env variable. Signed-off-by: Jason C. Nucciarone <[email protected]>
BREAKING CHANGE: The spack snap now sets SPACK_PYTHON to be
python3 interpreter bundled inside the snap. This interpreter
provides the `clingo` module so that Spack does not pull
a prebuilt clingo during bootstrap.
Other changes:
- Add support for arm64, armhf, ppc64el, s390x, and riscv64.
- Add spack core and binary dependencies to stage packages
to shorten Spack bootstrap time after installation.
- Compile clingo to ship prebuilt concretizer with Spack. This
removes the need to pull prebuilt binaries from Spack's remote
mirrors/CI pipeline.
- Compile yq since yq snap does not support riscv64 architecture.
Once support is added, switch back to yq snap to decrease snap
build time.
Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
The snap command in the `tox -e install` environment needed to have `--classic` appended since the Spack snap is classically confined. Also needed to prepend `sudo` to the zlib install/uninstall unit test commands since Spack now installs to /var/spack. Signed-off-by: Jason C. Nucciarone <[email protected]>
NucciTheBoss
force-pushed
the
enable-multiarch
branch
from
0582259 to
5214ee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for multiple architectures for the snap package build. New architectures include:
arm64ppc64els390xriscv64This pull request also adds other changes such as shipping a prebuilt clingo within the snap, builds yq from source (to support riscv64 builds), and bumps Spack to version 0.21.0.