Add support for clearing translations with an empty array

Update HasTranslations trait to handle empty arrays as valid input for clearing translations. Add a test to ensure empty arrays clear translations for the specified attribute.
spatie · Jan 3, 2025 · b75a9c7 · b75a9c7
1 parent de81937
commit b75a9c7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/HasTranslations.php b/src/HasTranslations.php
@@ -53,7 +53,7 @@ public function setAttribute($key, $value)
             return parent::setAttribute($key, $value);
         }
 
-        if (is_array($value) && ! array_is_list($value)) {
+        if (is_array($value) && (! array_is_list($value) || count($value) === 0)) {
             return $this->setTranslations($key, $value);
         }
 

diff --git a/tests/TranslatableTest.php b/tests/TranslatableTest.php
@@ -920,3 +920,10 @@ public function setAttributesExternally(array $attributes)
 
     expect($this->testModel->getTranslation('name', 'en'))->toEqual(['testValue_en']);
 });
+
+it('can treat an empty array as value for clearing translations', function () {
+    $this->testModel->name = [];
+    $this->testModel->save();
+
+    expect($this->testModel->getTranslations('name'))->toEqual([]);
+});