Handle null database values as null in translations #479
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the HasTranslations trait to return null for translations when the underlying database attribute is null. - Adjusted the logic in getTranslation to check if the raw attribute value is null before attempting to resolve translations. - Modified a test case to validate that null database values are treated as null in translations instead of empty strings.
|
This seems ok to me. Do you have any thoughts @vencelkatai ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests is originated from the conversation on #474 where @vencelkatai and i agreed on finding a way to have an implementation that satisfies our use cases and also keep the library consistent.
Changes
getTranslationmethod to check if the raw attribute value isnullusingself::getAttributeFromArray. If the attribute isnull, it will now treat the translation asnullinstead of falling back to an empty string.Why This Change Is Needed
Previously,
nullvalues in the database were treated inconsistently, being returned as empty strings in translations. This behavior could lead to unexpected results in applications that differentiate betweennulland empty strings. By aligning the translation output with the underlying database value, this change ensures more predictable and intuitive behavior.Next Steps
Please @freekmurze and @vencelkatai review the changes and share your feedback. If the approach aligns with expectations, I’ll proceed with further documentation or additional tests if necessary.
Thank you!