Remove the patch version on the license list #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch version was added in the most recent release of the SPDX license list to be compatible with the SPDX 3.0 release. This, however, broke the validation for the SPDX 2.X parser which checks that there is no patch version (per the 2.X spec). This commit removes the patch version from the license list version of the license list for the SPDX since this version of the license list only supports version 2.X Signed-off-by: Gary O'Neall <[email protected]>
|
cc: @puerco |
Signed-off-by: Gary O'Neall <[email protected]>
|
I updated the PR to allow for patch versions in the license list checking in addition to only using the major/minor versions when creating the license list version. |
This reverts commit a01c028. Based on feedback from the tech call on 2024 05 28, we don't want to relax the checking for license list versions
Based on the discussion on the tech call on 28 May 2024, I am reverting this commit so that the verify will fail if the patch version is present. |
|
Closing - replaced by PR #248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch version was added in the most recent release of the SPDX license list to be compatible with the SPDX 3.0 release. This, however, broke the validation for the SPDX 2.X parser which checks that there is no patch version (per the 2.X spec). This commit removes the patch version from the license list version of the license list for the SPDX since this version of the license list only supports version 2.X