chore: deprecate respecIsReady in favor of respec.ready #3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not yet remove document.respecIsReady, mark as deprecated only. - BREAKING CHANGE: respecIsReady no longer resolves with respecConfig. - Replace all usage of respecIsReady with respec.ready. - Support respecIsReady fallback in respecDocWriter for backward compat.
|
Only remaining occurrences of |
but update its behavior
sidvishnoi
force-pushed
the
deprecate-respecIsReady
branch
from
15c6b96 to
3166bc4
Compare
marcoscaceres
approved these changes
Sep 9, 2020
|
I wonder if we should mark is as breaking change. Based on my GitHub search, I didn't find anyone using the resolved |
|
Up to you - but this seems pretty safe to merge. |
|
IMO a breaking change is a breaking change, even when seemingly there is no real use anymore. But up to you, yes. |
|
Lets merge this as non-breaking 🤞 |
sidvishnoi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document.respecIsReady, mark as deprecated only.respecIsReadyno longer resolves withrespecConfig.document.respecIsReadywithdocument.respec.ready.respecIsReadyfallback inrespecDocWriterfor backward compat.Part of https://github.com/w3c/respec/issues/3089. Also see https://github.com/w3c/respec/pull/3082#discussion_r475473908