Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/respec-global): add toHTML() method #3403

Merged
merged 12 commits into from
Mar 29, 2021
Merged

feat(core/respec-global): add toHTML() method #3403

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c85800c
feat(core/respec-global): add toHTML() method
sidvishnoi Mar 24, 2021
6618584
use document.respec.toHTML() in respecDocWriter
sidvishnoi Mar 24, 2021
ce840d0
Add test, fix toHTML not returning html with DOCTYPE
sidvishnoi Mar 25, 2021
a2de38a
Merge branch 'main' into respec.toHTML
sidvishnoi Mar 25, 2021
3e2e647
tested wrong thing
sidvishnoi Mar 25, 2021
c819676
use toHTML() in testing exported docs
sidvishnoi Mar 25, 2021
0d201bb
fix test regex
sidvishnoi Mar 25, 2021
8795fa1
ensure test document has <!DOCTYPE html>
sidvishnoi Mar 25, 2021
df9a85d
test for meta generator
sidvishnoi Mar 25, 2021
dd226b4
Merge branch 'develop' into respec.toHTML
sidvishnoi Mar 25, 2021
00ff1b1
Merge branch 'develop' into respec.toHTML
sidvishnoi Mar 29, 2021
25b18b1
Merge branch 'develop' into respec.toHTML
sidvishnoi Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/exporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function rsDocToDataURL(mimeType, doc = document) {
return `data:${mimeType};charset=utf-8,${encodedString}`;
}

function serialize(format, doc) {
export function serialize(format, doc) {
const cloneDoc = doc.cloneNode(true);
cleanup(cloneDoc);
let result = "";
Expand Down
5 changes: 5 additions & 0 deletions src/core/respec-global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* This module also adds the legacy `document.respecIsReady` property for
* backward compatibility. It is now an alias to `document.respec.ready`.
*/
import { serialize } from "../core/exporter.js";
import { showWarning } from "../core/utils.js";
import { sub } from "./pubsubhub.js";

Expand Down Expand Up @@ -40,6 +41,10 @@ class ReSpec {
get ready() {
return this._respecDonePromise;
}

async toHTML() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Async in case we need it in future

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also add it in the future...

return serialize("html", document);
}
}

export function init() {
Expand Down
4 changes: 3 additions & 1 deletion tools/respecDocWriter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ async function evaluateHTML(version, timer) {
});
});
return exportDocument("html", "text/html");
} else {
} else if (!document.respec || !document.respec.toHTML) {
const { rsDocToDataURL } = await new Promise((resolve, reject) => {
require(["core/exporter"], resolve, err => {
reject(new Error(err.message));
Expand All @@ -249,6 +249,8 @@ async function evaluateHTML(version, timer) {
const dataURL = rsDocToDataURL("text/html");
const encodedString = dataURL.replace(/^data:\w+\/\w+;charset=utf-8,/, "");
return decodeURIComponent(encodedString);
} else {
return await document.respec.toHTML();
}

function timeout(promise, ms) {
Expand Down