Skip to content

Commit

Permalink
feat: increase dict decompression throughput (#1032)
Browse files Browse the repository at this point in the history
If we are canonicalizing the dictionary, we will likely canonicalize all
the values. For formats like bitpacking this substantially improves
throughput. In particular, we spend a lot of time preparing the indices
for chunked decoding and then pplying the patches.
  • Loading branch information
danking authored Oct 15, 2024
1 parent fa2a891 commit 0abe17d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion encodings/dict/src/array.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ impl ArrayTrait for DictArray {}

impl IntoCanonical for DictArray {
fn into_canonical(self) -> VortexResult<Canonical> {
take(self.values(), self.codes())?.into_canonical()
let canonical_values: Array = self.values().into_canonical()?.into();
take(canonical_values, self.codes())?.into_canonical()
}
}

Expand Down

0 comments on commit 0abe17d

Please sign in to comment.