Skip to content

Commit

Permalink
fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
robert3005 committed Oct 23, 2024
1 parent c09e5a2 commit 1a4dc16
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion pyvortex/test/test_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def test_to_batches(ds):

chunk0 = next(ds.to_batches(columns=["string", "bool"]))
assert chunk0.to_struct_array() == pa.array(
[record(x, columns=["string", "bool"]) for x in range(1 << 16)], type=schema
[record(x, columns=["string", "bool"]) for x in range(1_000_000)], type=schema
)


Expand Down
8 changes: 4 additions & 4 deletions vortex-serde/src/layouts/read/buffered.rs
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,9 @@ impl BufferedArrayReader {
.front()
.map(|((begin, _), _)| up_to_row < *begin)
})
.unwrap_or(true)
.unwrap_or(false)
{
vortex_bail!("Can't advance backwards")
vortex_bail!("Can't advance backwards {up_to_row}")
}

let mut new_arrays = mem::take(&mut self.arrays)
Expand Down Expand Up @@ -252,9 +252,9 @@ impl BufferedSelectorReader {
.front()
.map(|((begin, _), _)| up_to_row < *begin)
})
.unwrap_or(true)
.unwrap_or(false)
{
vortex_bail!("Can't advance backwards")
vortex_bail!("Can't advance backwards to {up_to_row}")
}

let mut new_selectors = mem::take(&mut self.selectors)
Expand Down

0 comments on commit 1a4dc16

Please sign in to comment.