Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter pushdown over layouts #1124

Merged
merged 51 commits into from
Nov 1, 2024
Merged
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
3537205
Filter pushdown
robert3005 Oct 21, 2024
8b99cc5
fix
robert3005 Oct 24, 2024
a571955
shortcircuit all true
robert3005 Oct 24, 2024
c402637
extract
robert3005 Oct 24, 2024
a862252
something
robert3005 Oct 24, 2024
75bbc3d
compiles
robert3005 Oct 24, 2024
75aa351
less
robert3005 Oct 25, 2024
4d1fc8b
less
robert3005 Oct 25, 2024
da63388
fixes
robert3005 Oct 25, 2024
a9995b9
fixes
robert3005 Oct 25, 2024
59b2608
clearer
robert3005 Oct 25, 2024
448b81c
print
robert3005 Oct 25, 2024
697d4f9
error
robert3005 Oct 25, 2024
ca6f501
dead
robert3005 Oct 27, 2024
ebf53e1
fixes
robert3005 Oct 28, 2024
412e7bc
more
robert3005 Oct 28, 2024
b6cfde0
inline lengths
robert3005 Oct 29, 2024
9b8a605
less
robert3005 Oct 29, 2024
eb839b7
less
robert3005 Oct 30, 2024
b90fda6
less
robert3005 Oct 30, 2024
773acad
fix
robert3005 Oct 30, 2024
277f2e0
less
robert3005 Oct 30, 2024
12ab636
clippy
robert3005 Oct 30, 2024
63a7e54
less
robert3005 Oct 31, 2024
b5c59a0
refactor
robert3005 Oct 31, 2024
3084223
assert
robert3005 Oct 31, 2024
930293a
renames
robert3005 Oct 31, 2024
f8d9dd6
changes
robert3005 Oct 31, 2024
f0836ad
nounwrap
robert3005 Oct 31, 2024
8c055bf
limit
robert3005 Oct 31, 2024
24f22ab
simpler
robert3005 Oct 31, 2024
0928585
less
robert3005 Oct 31, 2024
d56403f
docs
robert3005 Oct 31, 2024
bee7fe1
rename
robert3005 Oct 31, 2024
fe04b1f
fixes
robert3005 Oct 31, 2024
20e6583
comment
robert3005 Oct 31, 2024
0f8ad20
no
robert3005 Oct 31, 2024
19134d4
move
robert3005 Nov 1, 2024
49e2b8f
nounwrap
robert3005 Nov 1, 2024
f83443e
shuffle
robert3005 Nov 1, 2024
33d659c
less
robert3005 Nov 1, 2024
bec27b9
fixes
robert3005 Nov 1, 2024
32511a6
less
robert3005 Nov 1, 2024
2fa9b4a
comment
robert3005 Nov 1, 2024
2e3cd95
more
robert3005 Nov 1, 2024
5be421b
more
robert3005 Nov 1, 2024
78fd9d6
fix
robert3005 Nov 1, 2024
92f3475
miri
robert3005 Nov 1, 2024
52c6b83
more
robert3005 Nov 1, 2024
e0172d0
skip
robert3005 Nov 1, 2024
ca3e936
for real
robert3005 Nov 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move
  • Loading branch information
robert3005 committed Nov 1, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 19134d4b66cdb8f48bcd7dd78e2671e62d69a193
8 changes: 4 additions & 4 deletions vortex-serde/src/layouts/read/mask.rs
Original file line number Diff line number Diff line change
@@ -88,16 +88,16 @@ impl RowMask {

let array = array.as_ref();

if true_count == array.len() as u64 {
return Ok(Some(array.clone()));
}

let sliced = if self.len() == array.len() {
array
} else {
&slice(array, self.begin, self.end)?
};

if true_count == sliced.len() as u64 {
return Ok(Some(sliced.clone()));
}

let bitset = self
.values
.to_bitset()
Loading