Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return nice vorex-y error when trying to compare arrays with Struct dtype #1912

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Return nice vorex-y error when trying to compare arrays with Struct dtype #1912

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c4959b
.
AdamGS Jan 13, 2025
10ebbfb
.
AdamGS Jan 13, 2025
655a258
.
AdamGS Jan 13, 2025
9bfb03c
yet another embarassing commit to get this merged
AdamGS Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions vortex-array/src/compute/compare.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,14 @@ pub fn compare(
vortex_bail!("Compare operations only support arrays of the same type");
}

if left.dtype().is_struct() || right.dtype().is_struct() {
AdamGS marked this conversation as resolved.
Show resolved Hide resolved
vortex_bail!(
"Compare does not support arrays with Strcut DType, got: {} and {}",
left.dtype(),
right.dtype()
)
}

let result_dtype =
DType::Bool((left.dtype().is_nullable() || right.dtype().is_nullable()).into());

Expand Down
Loading