Avoid possible nil pointer when CompletionTime not set (#377)

spotify · Apr 20, 2022 · b8bd2e8 · b8bd2e8
1 parent dff92c5
commit b8bd2e8
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/apis/flinkcluster/v1beta1/flinkcluster_types_util.go b/apis/flinkcluster/v1beta1/flinkcluster_types_util.go
@@ -60,8 +60,14 @@ func (j *JobStatus) ShouldRestart(spec *JobSpec) bool {
 	if j == nil || !j.IsFailed() || spec == nil {
 		return false
 	}
-	var restartEnabled = spec.RestartPolicy != nil && *spec.RestartPolicy == JobRestartPolicyFromSavepointOnFailure
-	var jobCompletionTime = j.CompletionTime.Time
+
+	restartEnabled := spec.RestartPolicy != nil && *spec.RestartPolicy == JobRestartPolicyFromSavepointOnFailure
+
+	var jobCompletionTime time.Time
+	if j.CompletionTime != nil {
+		jobCompletionTime = j.CompletionTime.Time
+	}
+
 	return restartEnabled && j.IsSavepointUpToDate(spec, jobCompletionTime)
 }