Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ROW_NUMBER in JdbcAggregateJobQueryDao to improve performance #5575

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Use ROW_NUMBER in JdbcAggregateJobQueryDao to improve performance #5575

merged 2 commits into from
Dec 11, 2023

Conversation

onobc
Copy link
Contributor

@onobc onobc commented Nov 28, 2023

See #5524

@onobc onobc marked this pull request as draft November 29, 2023 02:38
@onobc onobc force-pushed the GH-5524-thinexecutions-perf-fix branch 2 times, most recently from 320ec57 to d7bf6b8 Compare December 6, 2023 00:36
@onobc onobc marked this pull request as ready for review December 6, 2023 00:41
@onobc onobc force-pushed the GH-5524-thinexecutions-perf-fix branch from 8d8a264 to 225ef87 Compare December 6, 2023 18:57
@onobc onobc requested review from cppwfs and corneil December 7, 2023 20:11
cppwfs
cppwfs reviewed Dec 7, 2023
View reviewed changes
...ore/src/main/java/org/springframework/cloud/dataflow/core/database/support/DatabaseType.java Show resolved Hide resolved
...main/java/org/springframework/cloud/dataflow/server/repository/JdbcAggregateJobQueryDao.java Show resolved Hide resolved
...main/java/org/springframework/cloud/dataflow/server/repository/JdbcAggregateJobQueryDao.java Outdated Show resolved Hide resolved
...st/java/org/springframework/cloud/dataflow/server/controller/AuditRecordControllerTests.java Outdated Show resolved Hide resolved
.../src/test/java/org/springframework/cloud/dataflow/server/db/migration/AbstractSmokeTest.java Outdated Show resolved Hide resolved
.../test/java/org/springframework/cloud/dataflow/server/db/migration/JobExecutionTestUtils.java Outdated Show resolved Hide resolved
...test/java/org/springframework/cloud/dataflow/server/db/migration/SqlServer2017SmokeTest.java Outdated Show resolved Hide resolved
...er/src/test/java/org/springframework/cloud/dataflow/server/db/support/DatabaseTypeTests.java Show resolved Hide resolved
...taflow-test/src/main/java/org/springframework/cloud/dataflow/server/db/ContainerSupport.java Show resolved Hide resolved
...st/src/main/java/org/springframework/cloud/dataflow/server/db/DB2_11_5_ContainerSupport.java Outdated Show resolved Hide resolved
@cppwfs
Copy link
Contributor

cppwfs commented Dec 7, 2023

Great job. Love the container support for tests. Just some nitpicks.

corneil
corneil approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@corneil corneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@onobc onobc force-pushed the GH-5524-thinexecutions-perf-fix branch from 33e790c to ab78c28 Compare December 11, 2023 19:21
@onobc onobc merged commit 9f9fdc2 into spring-cloud:main Dec 11, 2023
3 checks passed
@onobc onobc deleted the GH-5524-thinexecutions-perf-fix branch December 11, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppwfs cppwfs cppwfs left review comments

@corneil corneil corneil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onobc @cppwfs @corneil