Use new Prometheus RSocket client #6090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
commented
Dec 13, 2024
| @@ -32,7 +32,7 @@ | |||
| <commons-compress.version>1.26.2</commons-compress.version> | |||
| <!-- Specific version overrides to deal w/ CVEs --> | |||
| <nimbus-jose-jwt.version>9.39.3</nimbus-jose-jwt.version> | |||
| <prometheus-rsocket.version>2.0.0-M2</prometheus-rsocket.version> | |||
| <prometheus-rsocket.version>2.0.0-SNAPSHOT</prometheus-rsocket.version> | |||
There was a problem hiding this comment.
Note
As stated in the description... this will move to 2.0.0-M4 next then finally to 2.0.0.
onobc
commented
Dec 13, 2024
| @@ -112,5 +112,5 @@ scdf: | |||
| enabled: false | |||
| image: | |||
| repository: micrometermetrics/prometheus-rsocket-proxy | |||
| tag: 2.0.0-M2 | |||
There was a problem hiding this comment.
It would be nice to find a way to templatize this variable so that we set it in one place (even in a few places would be better than in every yml file in the installers).
Replaces the `micrometer.io:micrometer-registry-prometheus-simpleclient` with `micrometer.io:micrometer-registry-prometheus`. Also updates the Prometheus RSocket version from `2.0.0-M3` to `2.0.0-M4`. See spring-cloud#6068 See spring-cloud#6069
onobc
force-pushed
the
use-prometheus-rsocket-new-client2
branch
from
3e46431 to
74a2ce5
Compare
cppwfs
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
micrometer.io:micrometer-registry-prometheus-simpleclientwithmicrometer.io:micrometer-registry-prometheus.Also updates the Prometheus RSocket version from
2.0.0-M3to2.0.0-M4.See #6068
See #6069