Added metaDataUri to AppRegistrationResource #6098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added metaDataUri to AppRegistrationResource Added test for presence of metaDataUri Fixes spring-cloud#6092
corneil
added
the
review/at-least-one
…hanged resource. Adds metaDataUri to AppRegistryDocumentation and StreamDefinitionsDocumentation
cppwfs
approved these changes
Jan 2, 2025
| @@ -129,12 +129,15 @@ void findRegisteredApp() throws Exception { | |||
| mockMvc.perform( | |||
| post("/apps/sink/log1/3.0.0") | |||
| .queryParam("bootVersion", "3") | |||
| .param("uri", "maven://org.springframework.cloud.stream.app:log-sink-rabbit:3.0.0").accept(MediaType.APPLICATION_JSON) | |||
| .param("uri", "maven://org.springframework.cloud.stream.app:log-sink-rabbit:3.0.0") | |||
There was a problem hiding this comment.
We still need a test here for when there is no metadata sent on registration. I'll add it on merge.
|
LGTM Thanks for the contribution @corneil !!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added metaDataUri to AppRegistrationResource
Added test for presence of metaDataUri
Fixes #6092