Register Logback OnErrorConsoleStatusListener when using custom Logback file #43931
+99
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck file Prior to this commit, OnErrorConsoleStatusListener was not registered for a custom Logback configuration file. This commit registers OnErrorConsoleStatusListener when the Logback configuration is loaded from a custom Logback file that does not include any StatusListener. See spring-projectsgh-43822 Signed-off-by: Dmytro Nosan <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
|
Maybe Spring Boot should consistently register |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
OnErrorConsoleStatusListenerwas not registered for a custom Logback configuration file.This commit registers
OnErrorConsoleStatusListenerwhen the Logback configuration is loaded from a custom Logback file that does not include anyStatusListener.See gh-43822
It has also been tested with a native image.
A different approach is to register
OnErrorConsoleStatusListenerright afterreportConfigurationErrorsIfNecessary.main...nosan:spring-boot:43822-1