Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
mrclary committed Feb 19, 2024
1 parent f589ab4 commit b9d341f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions installers/macOS/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
import shutil
from logging import getLogger, StreamHandler, Formatter
from pathlib import Path
import platform
from setuptools import setup
from platform import machine

from spyder import get_versions

Expand Down Expand Up @@ -103,7 +103,8 @@ def disk_image_name(make_lite=False):
"""
Return disk image name
"""
dmg_name = f'Spyder-{machine()}'
mach = "_arm64" if "ARM64" in platform.version() else ""
dmg_name = f'Spyder{mach}'
if make_lite:
dmg_name += '-Lite'
dmg_name += '.dmg'
Expand Down
4 changes: 2 additions & 2 deletions spyder/workers/updates.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
import logging
import os
import os.path as osp
import platform
import tempfile
import traceback

# Third party imports
from packaging.version import parse
import platform
from qtpy.QtCore import QObject, Signal
import requests
from requests.exceptions import ConnectionError, HTTPError, SSLError
Expand Down Expand Up @@ -252,7 +252,7 @@ def _download_installer(self):
)
else:
name = 'Spyder{}{}.dmg'.format(
'_{mach}' if mach == 'arm64' else '',
f'_{mach}' if mach == 'arm64' else '',
'' if is_full_installer else '-Lite'
)

Expand Down

0 comments on commit b9d341f

Please sign in to comment.