-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add condabin
directory, relative to sys.executable
and provided pyexec
, to paths searched for conda executable
#21843
Conversation
I think this is missing a test because it's an important functionality. For that I suggest to temporarily remove |
condabin
directory, relative to sys.executable and provided pyexec, to paths searched for conda executable
63cd240
to
b781933
Compare
…s searched for conda executable. Add extra search paths for is_program_installed.
…e sure that a conda executable is still found.
On the good news front, I'd like to make a quick comment to say that I tested the Linux installer from this PR and it solves the problem of dead consoles in it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks @mrclary!
condabin
directory, relative to sys.executable and provided pyexec, to paths searched for conda executablecondabin
directory, relative to sys.executable
and provided pyexec
, to paths searched for conda executable
Description of Changes
For the cases where conda environments are in non-standard locations, including possibly Spyder's runtime environment for conda installations, a conda executable may not be found.
This PR adds
condabin
directories, relative to Spyder's runtime executable and an optional Python executable, to the paths searched.Optional extra search paths are added to
is_program_installed
.Issue(s) Resolved
Part of #20357.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: