-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Fix showing update status bar widget in our apps at startup and other fixes to the update process (Application) #21868
Conversation
Otherwise the "Check for updates" action in the Help menu would always appear as disabled to users.
That's because we're unable to give proper feedback to users about what to do to solve the error.
Checking locally the installer generated by this PR on Windows, I noticed that although now the status bar widget is visible, while doing the check for updates it showing the current Spyder version instead of the Edit: Seems like the same happens with the macOS installer |
As I mentioned in the OP, the problem is that we actually check for updates one minute after Spyder starts. So, during that time the But if you think we should keep that behavior, then I can fix it here. |
I guess then status bar should show something like:
or
then? Anyhow, indeed I think the previous behavior was better (at least more consistent than the current state of this PR), so please fix it here 👍 Just in case, to compare things in case someone else wants to chime in:
|
No problem, I just pushed a commit that should fix the issue. Please check if it's working as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ccordoba12 ! Checked the generated installer on Windows and things now are working as expected 👍
Description of Changes
sig_ready
signal after a check was performed so that theCheck for updates
action in the Help menu is enabled again (it's disabled while doing the check and it depends onsig_ready
to be enabled after the check ends).Issue(s) Resolved
Fixes #21861.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12