Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix showing update status bar widget in our apps at startup and other fixes to the update process (Application) #21868

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Mar 9, 2024

Description of Changes

  • This is a follow up of PR: Fix visibility of status bar widget that checks for Spyder updates (Application) #21851, which fixed the widget issue for our Linux experimental installer but broke things for our Windows and Mac apps.
  • Don't show generic errors while checking for updates to users because we can't give proper feedback to them on how to address the error. They'd only see a long and probably incomprehensible traceback, which wouldn't be really useful.
  • Always emit the sig_ready signal after a check was performed so that the Check for updates action in the Help menu is enabled again (it's disabled while doing the check and it depends on sig_ready to be enabled after the check ends).

Issue(s) Resolved

Fixes #21861.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

Otherwise the "Check for updates" action in the Help menu would always
appear as disabled to users.
That's because we're unable to give proper feedback to users about what
to do to solve the error.
@ccordoba12 ccordoba12 changed the title PR: Fix showing update status bar widget in our apps at startup (Application) PR: Fix showing update status bar widget in our apps at startup and other fixes to the update process (Application) Mar 9, 2024
@dalthviz
Copy link
Member

dalthviz commented Mar 11, 2024

Checking locally the installer generated by this PR on Windows, I noticed that although now the status bar widget is visible, while doing the check for updates it showing the current Spyder version instead of the Checking for updates status. So the status bar is not going from Checking for updates to Update available but from 5.5.2rc1 to Update available when launching Spyder:

update_status

Edit: Seems like the same happens with the macOS installer

@ccordoba12
Copy link
Member Author

ccordoba12 commented Mar 11, 2024

So the status bar is not going from Checking for updates to Update available but from 5.5.2rc1 to Update available when launching Spyder:

As I mentioned in the OP, the problem is that we actually check for updates one minute after Spyder starts. So, during that time the Check for updates message and (especially) the spinner would be visible to users.

But if you think we should keep that behavior, then I can fix it here.

@dalthviz
Copy link
Member

dalthviz commented Mar 12, 2024

As I mentioned in the OP, the problem is that we actually check for updates one minute after Spyder starts. So, during that time the Check for updates message and (especially) the spinner would be visible to users.

But if you think we should keep that behavior, then I can fix it here.

I guess then status bar should show something like:

  • 5.5.2rc1 -> Checking for updates -> Update available

or

  • 5.5.2rc1 -> Checking for updates -> 5.5.2rc1

then?

Anyhow, indeed I think the previous behavior was better (at least more consistent than the current state of this PR), so please fix it here 👍

Just in case, to compare things in case someone else wants to chime in:

  • How the status bar message is working with this PR as it is:

    • For the automatic check done on start up:
      • 5.5.2rc1 -> Update available
      • 5.5.2rc1
    • Manually triggered check:
      • Checking for updates -> Update available
      • Checking for updates -> 5.5.2rc1
  • The previous behavior (for the automatic check done on start up and manually triggered ones):

    • Checking for updates -> Update available
    • Checking for updates -> 5.5.2rc1

@ccordoba12
Copy link
Member Author

ccordoba12 commented Mar 12, 2024

Anyhow, indeed I think the previous behavior was better (at least more consistent than the current state of this PR), so please fix it here 👍

No problem, I just pushed a commit that should fix the issue. Please check if it's working as expected.

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 ! Checked the generated installer on Windows and things now are working as expected 👍

@ccordoba12 ccordoba12 merged commit f8f71e5 into spyder-ide:5.x Mar 12, 2024
23 checks passed
@ccordoba12 ccordoba12 deleted the issue-21861 branch March 12, 2024 22:56
ccordoba12 added a commit that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants