Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Make shortcuts for actions that control the debugger global again #23452

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

jsbautista
Copy link
Contributor

@jsbautista jsbautista commented Jan 13, 2025

Description of Changes

  • Changed shortcut contexts to make them accessible from anywhere in Spyder
  • That's how things were working in Spyder 5, so it was a regression introduced in Spyder 6.

Issue(s) Resolved

Fixes #22722

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@jsbautista

@ccordoba12 ccordoba12 added this to the v6.0.4 milestone Jan 13, 2025
@ccordoba12 ccordoba12 changed the title PR: Make all debugger shortcuts public PR: Make shortcuts for actions that control the debugger global again Jan 13, 2025
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @jsbautista! Besides taking a look at my comment below, please fix test_shortcuts_filtering with the new number of filtered shortcuts in that test.

spyder/plugins/debugger/widgets/main_widget.py Outdated Show resolved Hide resolved
@jsbautista jsbautista requested a review from ccordoba12 January 15, 2025 20:22
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsbautista!

@ccordoba12 ccordoba12 merged commit dbb946f into spyder-ide:master Jan 15, 2025
17 checks passed
@ccordoba12
Copy link
Member

@meeseeksdev please backport to 6.x

meeseeksmachine pushed a commit to meeseeksmachine/spyder that referenced this pull request Jan 15, 2025
ccordoba12 pushed a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugger keyboard shortcuts should also work when console has focus
2 participants