PR: Fix error when executing in a dedicated console and the interpreter doesn't have spyder-kernels installed or its right version #23511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
changed the title
ccordoba12
reviewed
Jan 19, 2025
| client.allow_rename = False | ||
| tab_text = self.disambiguate_fname(filename) | ||
| self.rename_client_tab(client, tab_text) | ||
| if (client): |
There was a problem hiding this comment.
Suggested change
| if (client): | |
| if client is not None: |
According to issue #21884, the problem happens when we reach this point and client is None. So we can improve a little bit this validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Check that the client was created, otherwise it will not be possible to rename
Issue(s) Resolved
Fixes #21884
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
@jsbautista