-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Handle empty options in pycodestyle and pydocstyle preferences #9231
Conversation
@ccordoba12 testing the behavior of the two options ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dalthviz for testing how things work. If that's the case, then I think we should leave both select and ignore options active and let users decide what they want to do with them.
But perhaps an explanation should be added to our docs. @CAM-Gerlach, what do think?
'filename': [filename.strip() | ||
for filename in cs_filename if filename], | ||
'select': [select.strip() for select in cs_select if select], | ||
'ignore': [ignore.strip() for ignore in cs_ignore if ignore], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty nice usage of list comprehensions! 👍
Merging because The question about mentioning this in our docs is a separate issue. |
Thanks, @ccordoba12 . I created spyder-ide/spyder-docs#96 to cover this. |
Description of Changes
Issue(s) Resolved
Fixes #9209
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz