Add repo href to source facts cache key #7925
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose extending the
__source
cache key used for saving repo source facts inwatchSource
to include the.href
of the associated anchor element.This is useful for cases where we are overriding/updating the
repo_url
link between different pages on the same site (useful for mono/multi-repo scenarios). As it currently stands, the cache will always hit if any repo facts have ever been queried and gives no consideration for caching per-distinct repo - resulting in the return of facts for the first rendered Source component for all others.I had also considered using
_md_hash()
on the.href
to reduce noise in the cache key, but I think it's best that @squidfunk make any final calls on what/how to make the cache value distinct - open to suggestions.Potential side-effects:
__source
are not removed or modified