Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precommit hooks #524

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Add precommit hooks #524

merged 1 commit into from
Nov 16, 2024

Conversation

ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Nov 16, 2024

Add hooks for precommit + some basic checks (and run flake8)

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.09%. Comparing base (4822f5a) to head (715380b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #524   +/-   ##
=======================================
  Coverage   83.09%   83.09%           
=======================================
  Files          27       27           
  Lines        1674     1674           
=======================================
  Hits         1391     1391           
  Misses        283      283           
Flag Coverage Δ
unittests 83.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ponyisi
Copy link
Collaborator Author

ponyisi commented Nov 16, 2024

Prompted by #451

Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye flake8 fix commits!

@BenGalewsky BenGalewsky merged commit 273ea34 into master Nov 16, 2024
42 checks passed
@BenGalewsky BenGalewsky deleted the 451_precommit branch November 16, 2024 23:04
@matthewfeickert
Copy link
Contributor

@ponyisi Given #451 (comment), I would suggest that you manually add running pre-commit to a lint workflow in your CI using https://github.com/pre-commit/action (unless you're planning on turning on pre-commit.ci in the very near future). Otherwise it is easy for people who didn't run pre-commit before pushing (or used --no-verify) to accidentally introduce non-passing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants