Added TopCPToolkit science image #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added TopCPToolkit science-image
ponyisi
reviewed
Dec 6, 2024
| @@ -0,0 +1,27 @@ | |||
| ARG BASE_IMAGE=gitlab-registry.cern.ch/atlas/athena/analysisbase:25.2.14 | |||
There was a problem hiding this comment.
Perhaps update default to 25.2.35
| RUN yum install -y https://repo.opensciencegrid.org/osg/3.6/osg-3.6-el9-release-latest.rpm && yum install -y osg-ca-certs | ||
| RUN yum install -y nc | ||
|
|
||
| COPY ./TopCPToolkit /TopCPToolkit |
There was a problem hiding this comment.
We need to figure out how to build TopCPToolkit within the container. The only complicated part of this is that the relevant repository is password-protected, so we need to inject the access token into the build somehow. But I've verified that we can do the git checkout and build inside the analysisbase container.
|
|
||
| USER servicex | ||
|
|
||
| COPY ./boot.bash_profile / |
There was a problem hiding this comment.
File needs to go to /root/.bash_profile
TopCP/boot.sh
Outdated
TopCP/generate/exampleInput.txt
Outdated
TopCP/configs/customConfig/reco.yaml
Outdated
There was a problem hiding this comment.
Example file should probably go somewhere else (we don't use this in the container, right?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TopCPToolkit transformer is still in development.