fix: Validate processing fields everywhere

[l0b0]

To reproduce the original issue:

1. Change the value of .providers[0]['processing:software']['IPF-S2L1C'] to something not a string, such as 2.6.
2. Run npm test.

The test passes even though the value should be considered invalid. I believe the reason for this is that anyOf requires that one of the sub-schemas are valid, not that one of the sub-schema structures are present. So even if some processing property values are invalid, as long as there is at least one valid value the JSON passes validation.

Caveat: Some unit tests would be in order to make sure the schema does the right thing in many more cases. If you're interested I can add some of those as well.

[m-mohr]

Hmm, interesting. Thanks for catching this. I'll investigate...

[l0b0]

Ping?

[l0b0]

Broken because of #14.

[m-mohr]

Indeed, the anyOf is a problem. It's an issue in all extensions basically. If one of them is fullfilled, the others don't need to be fulfilled. You can fix this to some degree by making pure field validation with no field requirements in allOf and then add the requirements in anyOf. An example how I believe it can be solved: 8045be9
Nevertheless, this still does not solve the issue for the other potential occurances and only for provider.

PS: I'm basically the only one who's doing all the JSON Schema maintenance for the whole STAC spec + extension, which I have like 1-2 hours per month allocated for. Fixing this here and throughout the STAC ecosystem will need a funding effort ( @cholmes ) so that someone can work on this for some time...

[l0b0]

I've changed these to Jest.

[m-mohr]

I have updated the JSON Schema to properly validate fields and requirements in #18 so this might be obsolete

[l0b0]

I have updated the JSON Schema to properly validate fields and requirements in #18 so this might be obsolete

The "should fail validation without any summaries processing: properties" test fails with the schema in the main branch. Also, this adds tests which are easier to read and understand in isolation than the schema itself, making sure that future changes don't break anything.

[m-mohr]

The "should fail validation without any summaries processing: properties" test fails with the schema in the main branch.

Yes, but that is intended (if I understand the tests correctly) as there are still processing properties in providers. For Collections, it checks whether any place contains processing properties, so if any of summaries, assets, item_assets or providers have processing properties, the requirement for specifying at least one processing property is fulfilled. So the tests need to be fixed. See the note below the table for details: https://github.com/stac-extensions/processing#item-properties-and-collection-provider-fields

[l0b0]

It also fails "should fail validation with invalid providers processing:software value".

[l0b0]

The "should fail validation without any summaries processing: properties" test fails with the schema in the main branch.

Yes, but that is intended (if I understand the tests correctly) as there are still processing properties in providers.

I'll make sure it tests that.

[m-mohr]

It also fails "should fail validation with invalid providers processing:software value".

Haven't run your tests as I'm on my non-dev machine right now, but if I validate invalid stuff processing:software in providers in some online json schema validator it correctly throws an exception. So I guess something with your tests is wrong, maybe the expected error message has changed. Maybe it's worth checking the tests again. I've verified with around 25 different files and configurations that the schema works so I don't expect any major issues any more.

[l0b0]

Looks like you fixed the original issue, thank you! The tests should still be relevant.

[l0b0]

Anything missing to get this merged?

[l0b0]

I don't work with STAC anymore, so I've unsubscribed from this. Please @ me if you would like some further feedback.