-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initial migration for Workspaces and pipeline step #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
reviewed
Jan 16, 2025
lukehinds
reviewed
Jan 16, 2025
JAORMX
added a commit
to JAORMX/codegate
that referenced
this pull request
Jan 16, 2025
This adds a simple and unimplemented REST API for workspaces. Workspaces will be the base for all other resources in terms of REST resource mapping, so these go first. These are initially left entirely unimplemented as stacklok#600 needs to merge Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
added a commit
to JAORMX/codegate
that referenced
this pull request
Jan 16, 2025
This adds a simple and unimplemented REST API for workspaces. Workspaces will be the base for all other resources in terms of REST resource mapping, so these go first. These are initially left entirely unimplemented as stacklok#600 needs to merge Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
reviewed
Jan 16, 2025
Related: #454 We noticed most of the incoming-requests which contain a code-snippet only list a relative path with respect to where the code editor is opened. This would make difficult to accurately distinguish between repositories in Codegate. For example, a user could open 2 different code Python repositorites in different session and both repositories contain a `pyproject.toml`. It would be impossible for Codegate to determine the real repository of the file only using the relative path. Hence, the initial implementation of Workspaces will rely on a pipeline step that is able to take commands a process them. Some commands could be: - List workspaces - Add workspace - Switch active workspace - Delete workspace It would be up to the user to select the desired active workspace. This PR introduces an initial migration for Workspaces and the pipeline step with the `list` command.
aponcedeleonch
force-pushed
the
workspaces-step
branch
from
January 16, 2025 16:21
afd14df
to
29f99aa
Compare
JAORMX
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elegant AF
shipit 🚢
JAORMX
added a commit
to JAORMX/codegate
that referenced
this pull request
Jan 17, 2025
This adds a simple and unimplemented REST API for workspaces. Workspaces will be the base for all other resources in terms of REST resource mapping, so these go first. These are initially left entirely unimplemented as stacklok#600 needs to merge Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
added a commit
to JAORMX/codegate
that referenced
this pull request
Jan 17, 2025
This adds a simple and unimplemented REST API for workspaces. Workspaces will be the base for all other resources in terms of REST resource mapping, so these go first. These are initially left entirely unimplemented as stacklok#600 needs to merge Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
added a commit
to JAORMX/codegate
that referenced
this pull request
Jan 17, 2025
This adds a simple and unimplemented REST API for workspaces. Workspaces will be the base for all other resources in terms of REST resource mapping, so these go first. These are initially left entirely unimplemented as stacklok#600 needs to merge Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
added a commit
to JAORMX/codegate
that referenced
this pull request
Jan 17, 2025
This adds a simple and unimplemented REST API for workspaces. Workspaces will be the base for all other resources in terms of REST resource mapping, so these go first. These are initially left entirely unimplemented as stacklok#600 needs to merge Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
added a commit
to JAORMX/codegate
that referenced
this pull request
Jan 17, 2025
This adds a simple and unimplemented REST API for workspaces. Workspaces will be the base for all other resources in terms of REST resource mapping, so these go first. These are initially left entirely unimplemented as stacklok#600 needs to merge Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
added a commit
that referenced
this pull request
Jan 17, 2025
This adds a simple and unimplemented REST API for workspaces. Workspaces will be the base for all other resources in terms of REST resource mapping, so these go first. These are initially left entirely unimplemented as #600 needs to merge Signed-off-by: Juan Antonio Osorio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #454
We noticed most of the incoming-requests which contain a code-snippet only list a relative path with respect to where the code editor is opened. This would make difficult to accurately distinguish between repositories in Codegate. For example, a user could open 2 different code Python repositorites in different session and both repositories contain a
pyproject.toml
. It would be impossible for Codegate to determine the real repository of the file only using the relative path.Hence, the initial implementation of Workspaces will rely on a pipeline step that is able to take commands a process them. Some commands could be:
It would be up to the user to select the desired active workspace.
This PR introduces an initial migration for Workspaces and the pipeline step with the
list
command.Continue sample output: