-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for uploading a Stainless config file in addition to the OpenAPI spec file #9
Merged
dgellow
merged 11 commits into
main
from
sam/sta-2798-update-upload-github-action-to-support-a-stainless-config-in
Nov 28, 2023
Merged
Add support for uploading a Stainless config file in addition to the OpenAPI spec file #9
dgellow
merged 11 commits into
main
from
sam/sta-2798-update-upload-github-action-to-support-a-stainless-config-in
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, use direct upload instead of S3 presigned URLs.
Co-authored-by: Robert Craigie <[email protected]>
When explicitly setting the Content-Type header with fetch, the multipart form boundaries are removed, causing issues for the server processing the form. See https://stackoverflow.com/questions/43500514/how-to-post-with-multipart-form-data-header-and-formdata-using-fetch
Tested this branch via a GitHub workflow, it works but we get a deprecation warning:
I will look into it. |
dgellow
deleted the
sam/sta-2798-update-upload-github-action-to-support-a-stainless-config-in
branch
November 28, 2023 03:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does three main changes:
POST /api/spec
has been updated to support amultipart/form-data
body, making it possible to provide both the spec file and a Stainless config file. When the new inputconfig_path
is provided both the spec and config files will be uploaded, otherwise only the spec file will be uploaded.POST /api/spec
instead of the previous 3-steps dance.