Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_sequencer_node): creating communication clients for class manager and serra compiler #3393

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lev-starkware
Copy link
Contributor

@lev-starkware lev-starkware commented Jan 16, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

…ss manager and serra compiler

commit-id:a12ae4a1
@lev-starkware lev-starkware changed the title feat(starknet_sequencer_node): creating communication clients for the class manager and serra compiler feat(starknet_sequencer_node): creating communication clients for class manager and serra compiler Jan 16, 2025
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lev-starkware)


crates/starknet_sequencer_node/src/clients.rs line 127 at r1 (raw file):

    pub fn get_class_manager_shared_client(&self) -> Option<SharedClassManagerClient> {
        get_shared_client!(self, class_manager_client)
    }

Please add a todo: there are too many functions in here, we need to sort them in a meaningful way.

Two suggestions

X_local
X_shared
Y_local
Y_shared

or

X_local
Y_local
...
X_shared
Y_shared

Code quote:

    pub fn get_class_manager_shared_client(&self) -> Option<SharedClassManagerClient> {
        get_shared_client!(self, class_manager_client)
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants