This repository has been archived by the owner on Nov 8, 2023. It is now read-only.
Add counterfactual deployment test case #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Ah, it looks like I accidentally deleted a line when adding a helper, it has now been resolved. |
geoknee
approved these changes
Oct 18, 2023
| const userOp: UserOperationStruct = { | ||
| sender: precomputedSCWAddress, | ||
| nonce: 0, | ||
| initCode, |
There was a problem hiding this comment.
Checking my understanding: won't it be a waste of gas to include this initcode with every l1 userop ?
There was a problem hiding this comment.
I think so, yes. You want to include it only if the wallet isn't already deployed.
There was a problem hiding this comment.
Good point! We'd pay slightly more gas due to the increased callData size of including the initCode if we included it with every UserOperation.
NiloCK
reviewed
Oct 18, 2023
Comment on lines
+24
to
+44
| address( | ||
| uint160( | ||
| uint( | ||
| keccak256( | ||
| abi.encodePacked( | ||
| bytes1(0xff), | ||
| address(this), | ||
| salt, | ||
| keccak256( | ||
| abi.encodePacked( | ||
| type(SCBridgeWallet).creationCode, | ||
| abi.encode(owner), | ||
| abi.encode(intermediary), | ||
| abi.encode(entrypoint) | ||
| ) | ||
| ) | ||
| ) | ||
| ) | ||
| ) | ||
| ) | ||
| ); |
There was a problem hiding this comment.
A beautiful pyramid calculation.
NiloCK
reviewed
Oct 18, 2023
|
Really great - thanks @lalexgap. |
NiloCK
approved these changes
Oct 18, 2023
Co-authored-by: Colin Kennedy <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test case to test the
Entrypointcontract deploying ourSCBridgeWalleton demand using our contract factory. Instead of deploying theSCBridgeWalletbefore submitting theUserOperation, the test specifies theinitcodewhich points to our factory. When theEntryPointreceives theUserOperationit checks the precomputed address and deploys theSCBridgeWalletfor us.TODO:
initCodeand update our deploy script to just prefund theSCBridgeWalletaddresses instead of deploying to them.