make SomeFuture public #556
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomrsantos
force-pushed
the
make-SomeFuture-public
branch
from
d6a1f8a to
ef93a15
Compare
arnetheduck
reviewed
Oct 18, 2024
| @@ -60,7 +60,7 @@ type | |||
| FutureCompletedError* = object of FutureError | |||
| ## Error raised when trying access the error of a completed Future | |||
|
|
|||
| SomeFuture = Future|InternalRaisesFuture | |||
| SomeFuture* = Future|InternalRaisesFuture | |||
There was a problem hiding this comment.
this type is deliberately private because the whole idea of how this is implemented might change soonish - for now, it's better to use InternalRaisesFuture directly in code that needs it which will make it easy to find, once a stable future type is created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes it possible to not use
InternalRaisesFuturein procs like https://github.com/vacp2p/nim-libp2p/pull/1175/files.