Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use static linking on Linux and MacOS, dynamic on Windows #81

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Use static linking on Linux and MacOS, dynamic on Windows #81

wants to merge 12 commits into from

Conversation

bhartnett
Copy link
Contributor

@bhartnett bhartnett commented Jan 14, 2025 •
edited
Loading

Changes in this PR:

  • We now only support static linking on Linux and MacOS. Windows is still only using dynamic linking.
  • Dynamically linking can be enabled on Linux and MacOS using the 'rocksdb_dynamic_linking' flag but this is not documented and the dynamic libraries are not built in nimble install. They can be built using one of the build scripts if needed.
  • Updated the wrapper generation so that we don't need to use dynlibOverride when using static linking.
  • Static libs are copied to the same directory as the dll
  • Cleaned up the librocksdb.nim file which imports the rocksdb wrapper.
  • Updated the tasks in the nimble file.

@bhartnett bhartnett requested a review from arnetheduck January 15, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnetheduck arnetheduck Awaiting requested review from arnetheduck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bhartnett