Unroll nibble ops #2894
Merged
Unroll nibble ops #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
force-pushed
the
smaller-nibbles
branch
2 times, most recently
from
51c4936 to
4b99ee7
Compare
arnetheduck
force-pushed
the
smaller-nibbles
branch
from
4b99ee7 to
d9726ad
Compare
arnetheduck
force-pushed
the
smaller-nibbles
branch
from
87514b3 to
5241996
Compare
A bit unexpectedly, nibble handling shows up in the profiler mainly because the current impl is tuned towards slicing while the most common operation is prefix comparison - since the code is simple, might has well get rid of some of the excess fat by always aliging the nibbles to the byte buffer.
arnetheduck
force-pushed
the
smaller-nibbles
branch
from
64aa6bd to
23f8ced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit unexpectedly, nibble handling shows up in the profiler - this PR reuses unrolling similar to that of
stintto process nibbles in 16-nibble chunks using uint64 as underlying storage instead of byte